Skip to content

Conversation

@dkalamar
Copy link
Contributor

  • Fixes spelling error for class SesssionExemptMixin to SessionExemptMixin

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Sep 30, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 30, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@hussein-awala
Copy link
Member

@eladkal @ephraimbuddy IMHO this change is safe because the class is not part of the public API, could you check it?

@eladkal eladkal added this to the Airflow 2.7.2 milestone Oct 1, 2023
@eladkal eladkal added the type:misc/internal Changelog: Misc changes that should appear in change log label Oct 1, 2023
@uranusjr uranusjr merged commit 63945c7 into apache:main Oct 2, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 2, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

ephraimbuddy pushed a commit that referenced this pull request Oct 5, 2023
Co-authored-by: David Kalamarides <david.kalamarides@capitalone.com>
(cherry picked from commit 63945c7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants