Parse 'docker context ls --format=json' correctly #34711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
approved these changes
Oct 2, 2023
uranusjr
force-pushed
the
docker-context-list-of-dict
branch
2 times, most recently
from
ed1de75 to
9cebb55
Compare
jedcunningham
approved these changes
Oct 2, 2023
Taragolis
approved these changes
Oct 2, 2023
Apparently the command outputs *multiple lines of JSON objects* when there are more than one context, not one JSON array of objects. Pretty f-ed up if you ask me but it's what it is.
uranusjr
force-pushed
the
docker-context-list-of-dict
branch
from
9cebb55 to
037bbfa
Compare
eladkal
approved these changes
Oct 2, 2023
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit 1928498)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the command outputs multiple lines of JSON objects when there are more than one context, not one JSON array of objects. Pretty f-ed up if you ask me but it's what it is.
This should fix the JSON error mentioned in #34701 (comment) (not the ModuleNotFoundError)
cc @Lee-W