Check if the lower of provided values are sensitives in config endpoint

[hussein-awala]

No description provided.

[uranusjr]

We don’t currently normalise entries in sensitive_config_values to lowercase. Should we do that to ensure things are compared correctly?

[ephraimbuddy]

Instead of this, I think we should do what we do in the webserver

airflow/airflow/www/views.py

Lines 3840 to 3845 in f349fda

	updater = configupdater.ConfigUpdater()
	updater.read(AIRFLOW_CONFIG)
	for sect, key in conf.sensitive_config_values:
	if updater.has_option(sect, key):
	updater[sect][key].value = "< hidden >"
	config = str(updater)

.

[hussein-awala]

I cannot fix the problem, because it checks if the value exists in the configuration as it is. But since we don't read any configuration from the user in this view, it's safe because all the configuration in both side (sensitive dict and configuration dict) are in low format.

[potiuk]

Agree with @hussein-awala . I think the proposed way is right. The "www/views.py" code displays all the sections/options from the config and then then from sensitive_config_values. What we are preventing here is that differently cased section/option is passed by the user, so the source of section/key are not the config itself, but external to it. We can safely assume that the config has the right sections/keys (that's why the code in views.py works). But we cannot make the same assumption about the values passed by the user so we have to lowercase them.