Order cherrypicking candidates by the closed date #34739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the candidates are ordered by the PR number but ordering by the closed date is better and will help avoid some conflicts
ephraimbuddy
requested review from
ashb,
jedcunningham,
kaxil,
pierrejeambrun and
potiuk
as code owners
| ) | ||
|
|
||
| milestone_issues = sorted( | ||
| milestone_issues, key=lambda x: x.closed_at if x.closed_at else x.created_at, reverse=True |
Member
There was a problem hiding this comment.
I didn't understand the need of reverse here:
(older commits first)
Contributor
Author
There was a problem hiding this comment.
Just so I can cherrypick from the bottom of the list upwards. The last item would be the oldest
Contributor
Author
There was a problem hiding this comment.
The sorting is to get an order based on date then reverse it so that oldest commit is listed last
hussein-awala
approved these changes
Oct 3, 2023
ephraimbuddy
added a commit
that referenced
this pull request
Oct 5, 2023
Currently, the candidates are ordered by the PR number but ordering by the closed date is better and will help avoid some conflicts (cherry picked from commit 90628e4)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the candidates are ordered by the PR number but ordering by the closed date is better and will help avoid some conflicts