Reset stats logger in daemon context to reinitialize in child process#34769
Reset stats logger in daemon context to reinitialize in child process#34769pavansharma36 wants to merge 10 commits intoapache:mainfrom
Conversation
hussein-awala
left a comment
There was a problem hiding this comment.
Could you try to reproduce the error in a new test and pass it with this change?
|
@hussein-awala Actually I am not aware of writing test with daemon context. And this issue requires statsd metrics enabled and creating connection with actual host |
|
Can you please rebase.? It's indeed hard to test it. |
|
This seems a bit messy to me. Perhaps we should create a wrapper to |
|
I think it's better to redo this fix after #34945 - that one seems almost ready and I think fixing the problem you mentioned will be a bit different once it is merged. |
|
Also please set up pre-commit locally and correct the coding style issues. See the contribution guide for details. |
|
Will raise new PR |
related: #33897
Clear stats logger instance to reinitialize in child process.