Fix autodetect_docker_context for list of dict case #34779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarsharma2
requested review from
ashb,
jedcunningham and
potiuk
as code owners
ephraimbuddy
reviewed
Oct 5, 2023
utkarsharma2
force-pushed
the
FixAutodetect_docker_context
branch
from
40682bb to
2028664
Compare
utkarsharma2
force-pushed
the
FixAutodetect_docker_context
branch
from
2028664 to
c4d525b
Compare
Contributor
|
As follow up I guess we could try to run this step by use python-on-whales so many problems happen last time with this part and |
ephraimbuddy
approved these changes
Oct 5, 2023
Contributor
Author
|
@Taragolis I can give it a shot. :) |
hussein-awala
approved these changes
Oct 5, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 6, 2023
* Fix autodetect_docker_context for list of dict case * Handle the case of dict (cherry picked from commit 5c2dc53)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In breeze's autodetect_docker_context() there is one case that missed, when the output of
docker context ls --format=json"is[{"Name": "desktop-linux", "DockerEndpoint": "unix://desktop-linux"}]. This PR aims to handle this case.