Remove unused argument metadata from es_read and make clearly private

[dstandish]

Not used.

[jedcunningham]

We should consider es_read as private, yeah?

[dstandish]

We should consider es_read as private, yeah?

Oh boy...
well... maybe technically we can't but 🤷

[dstandish]

airflow should make things all private unless a @public decorator is added.... default private everywhere

[jedcunningham]

My take is it's internal to the ES log handler, shouldn't be a problem to remove it.

[dstandish]

My take is it's internal to the ES log handler, shouldn't be a problem to remove it.

well, if we're gonna do that, should we go all out and make it _es_read / :meta private:?

[eladkal]

My take is it's internal to the ES log handler, shouldn't be a problem to remove it.

I'm fine with it but lets at least add entry about this in the change log that explains this decision. Simply log it at the top of the provider change log I will handle the style and place it in the correct place during release.

[jedcunningham]

well, if we're gonna do that, should we go all out and make it _es_read / :meta private:?

Works for me.

[dstandish]

I'm fine with it but lets at least add entry about this in the change log that explains this decision. Simply log it at the top of the provider change log I will handle the style and place it in the correct place during release.

OK thanks Elad

[dstandish]

ok @eladkal i added the docs note. i also renamed it _es_read. if you think the method rename goes too far LMK