Skip to content

Conversation

@imroc
Copy link
Contributor

@imroc imroc commented Jun 11, 2018

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    In previous PR AIRFLOW-2581, I changed the default value of
    autocommit to True in DbApiHook.run(), which may cause some performance
    issues, so I changed it back to False.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

…run()

In previous PR (AIRFLOW-2581), I changed the default value  of
autocommit to True in DbApiHook.run(), which may cause some performance
issues, so I changed it back to False.
@imroc
Copy link
Contributor Author

imroc commented Jun 11, 2018

@Fokko @yrqls21 PTAL. In my previous PR AIRFLOW-2581, I changed the default value of
autocommit to True in DbApiHook.run(), which may cause some performance
issues, so I changed it back to False.

@KevinYang21
Copy link
Member

KevinYang21 commented Jun 11, 2018

LGTM, ty for the quick turnaround.

@asfgit asfgit closed this in cae918e Jun 11, 2018
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
… in DbApiHook.run()

In previous PR (AIRFLOW-2581), I changed the
default value  of
autocommit to True in DbApiHook.run(), which may
cause some performance
issues, so I changed it back to False.

Closes apache#3487 from imroc/AIRFLOW-2591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants