Skip to content

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented Oct 14, 2023

Following #33956 PR aws/serverless-application-model#3282 has been merged and released in https://github.com/aws/serverless-application-model/releases/tag/v1.75.0 bumping moto to see if the issue is resolved

@eladkal eladkal added this to the Airflow 2.7.3 milestone Oct 14, 2023
@eladkal eladkal added the type:misc/internal Changelog: Misc changes that should appear in change log label Oct 14, 2023
@eladkal eladkal requested a review from hussein-awala October 14, 2023 17:02
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The failed tests and static checks don't seem related to this PR 🤔

@eladkal
Copy link
Contributor Author

eladkal commented Oct 14, 2023

LGTM! The failed tests and static checks don't seem related to this PR 🤔

Yes it will be fixed in #34941

@potiuk
Copy link
Member

potiuk commented Oct 14, 2023

There are few other tests failing because other dependency releases also caused problems:

WTForms breaking FAB: Workarounded in #34943
Sentry: #34946

I rebased also #34941 on top of the two fixes above and hopefully we will get "green" main again so that you can rebase it.

@potiuk
Copy link
Member

potiuk commented Oct 14, 2023

Rebased after merging #34941

@eladkal eladkal merged commit 27443ec into apache:main Oct 15, 2023
@eladkal eladkal deleted the aws branch October 15, 2023 05:02
potiuk pushed a commit that referenced this pull request Oct 29, 2023
(cherry picked from commit 27443ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants