Fix the dags count filter in webserver home page #34944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
potiuk
approved these changes
Oct 14, 2023
Member
|
I wonder if we could have a unit test for that one to avoid similar brekages? |
Member
Author
I just added a test for it, it fails without this change. |
potiuk
approved these changes
Oct 14, 2023
2 tasks
This was referenced Oct 27, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 29, 2023
* Fix the dags count filter in webserver home page * Add a test to avoid breaking the count in the future (cherry picked from commit 54e7e08)
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 30, 2023
* Fix the dags count filter in webserver home page * Add a test to avoid breaking the count in the future (cherry picked from commit 54e7e08)
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revert a change added by mistake to #33810, this change introduced a bug in the dags count in the webserver home page. (b470c6b#r129957716)