Skip to content

Conversation

@michalsosn
Copy link
Contributor

Closes: #10385

This change adds the on_kill method to the DataprocInstantiateWorkflowTemplateOperator and DataprocInstantiateInlineWorkflowTemplateOperator. This method is used to cancel the Dataproc workflow by name (which is the workflow ID), with the name saved as a field on the operator object.

There is a cancel_on_kill flag (defaulting to true) that makes this behavior configurable. This flag is also present in the DataprocSubmitJobOperator, which I modeled this behavior after.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Oct 16, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 16, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@michalsosn
Copy link
Contributor Author

FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/airflow/airflow/airflow-site/docs-archive/apache-airflow-providers-opensearch'

I think I can assume the error in CI is not caused by my change.

@potiuk
Copy link
Member

potiuk commented Oct 16, 2023

FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/airflow/airflow/airflow-site/docs-archive/apache-airflow-providers-opensearch'

I think I can assume the error in CI is not caused by my change.

Yes. Addressed in #34963

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for thorough tests.

@potiuk potiuk merged commit 0b49f33 into apache:main Oct 16, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 16, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add on_kill method to DataprocInstantiateWorkflowTemplateOperator

2 participants