Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Oct 18, 2023

The "test/operators" are one of the longest tests of ours - mainly because of a lot of Python virtualenv operators taking a lot of time to create and tear-down virtualenvs. They contributed a lot to the "Other" category making it one that run for the longest time.

In order to improve usage of parallel cores, we separate operator tests to a new "Operators" test typ and let them run in parallel to Other tests - this should help in speeding up the tests overall by around 3-4 minutes on self-hosted runners.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk requested review from Taragolis, eladkal, ephraimbuddy, jedcunningham and josh-fell and removed request for ashb and jedcunningham October 18, 2023 00:32
@potiuk potiuk force-pushed the better-parallelise-tests branch from 250c7d7 to 9023781 Compare October 18, 2023 01:05
@potiuk
Copy link
Member Author

potiuk commented Oct 18, 2023

Looks like this PR speeds up test execution on self-hosted runners from ~20 minutes to 15 minutes.

@potiuk potiuk requested a review from uranusjr October 18, 2023 01:09
@potiuk
Copy link
Member Author

potiuk commented Oct 18, 2023

Failing PROD image will be fixed after #35004 is merged.

The "test/operators" are one of the longest tests of ours - mainly
because of a lot of Python virtualenv operators taking a lot of
time to create and tear-down virtualenvs. They contributed a lot to
the "Other" category making it one that run for the longest time.

In order to improve usage of parallel cores, we separate operator tests
to a new "Operators" test typ and let them run in parallel to Other
tests - this should help in speeding up the tests overall by around
3-4 minutes on self-hosted runners.
@potiuk potiuk force-pushed the better-parallelise-tests branch from 9023781 to 13c1866 Compare October 18, 2023 08:09
@potiuk potiuk merged commit 1b4307b into apache:main Oct 18, 2023
@potiuk potiuk deleted the better-parallelise-tests branch October 18, 2023 10:54
potiuk added a commit that referenced this pull request Oct 29, 2023
The "test/operators" are one of the longest tests of ours - mainly
because of a lot of Python virtualenv operators taking a lot of
time to create and tear-down virtualenvs. They contributed a lot to
the "Other" category making it one that run for the longest time.

In order to improve usage of parallel cores, we separate operator tests
to a new "Operators" test typ and let them run in parallel to Other
tests - this should help in speeding up the tests overall by around
3-4 minutes on self-hosted runners.

(cherry picked from commit 1b4307b)
@potiuk potiuk added this to the Airflow 2.7.3 milestone Oct 29, 2023
@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants