Skip to content

Conversation

@RNHTTR
Copy link
Contributor

@RNHTTR RNHTTR commented Oct 19, 2023

Make the --package-filter flag a bit more clear, and demonstrate that it can be used for multiple packages.

Make the --package-filter flag a bit more clear, and demonstrate that it can be used for multiple packages.
@RNHTTR RNHTTR changed the title Update README.rst Update docs README.rst to clarify --package-filter usage Oct 19, 2023
@potiuk
Copy link
Member

potiuk commented Oct 19, 2023

Just realized @RNHTTR @utkarsharma2 @Taragolis : We have not finished switching from --package-filter to command parameters, it used to be that `--package-fllter had autocompletion and list of packages but before Summit with @amoghrajesh we moved it command option - see #35067

@github-actions
Copy link

github-actions bot commented Dec 4, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 4, 2023
@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 10, 2023
@eladkal eladkal added this to the Airflow 2.8.1 milestone Dec 10, 2023
@eladkal eladkal added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Dec 10, 2023
Comment on lines +483 to +485
"The list of short hand names can be found in --help output "
"Multiple package filters can be applied by passing the flag multiple times. "
"For example --package-filter apache-airflow --package-filter apache-airflow-providers-<provider>",
Copy link
Member

@potiuk potiuk Dec 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"The list of short hand names can be found in --help output "
"Multiple package filters can be applied by passing the flag multiple times. "
"For example --package-filter apache-airflow --package-filter apache-airflow-providers-<provider>",
"The list of short hand names can be found in --help output "
"Multiple package filters can be applied by passing the flag multiple times. "
"For example --package-filter apache-airflow --package-filter apache-airflow-providers-<provider>. "
"You can also specify glob-pattern. For example --package-filter '*providers*'." ,

@potiuk
Copy link
Member

potiuk commented Dec 10, 2023

Approved - proposed one NIT: improvement (--package-filter allows glob pattern matching), you will akso need to apply static checks to include the description in the help screenshots.

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1
Test needs fixing

@RNHTTR
Copy link
Contributor Author

RNHTTR commented Jan 2, 2024

Closed by: #36287

@RNHTTR RNHTTR closed this Jan 2, 2024
@RNHTTR RNHTTR deleted the patch-7 branch January 2, 2024 23:28
@ephraimbuddy ephraimbuddy removed this from the Airflow 2.8.1 milestone Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants