-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Update docs README.rst to clarify --package-filter usage #35045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Make the --package-filter flag a bit more clear, and demonstrate that it can be used for multiple packages.
|
Just realized @RNHTTR @utkarsharma2 @Taragolis : We have not finished switching from |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
| "The list of short hand names can be found in --help output " | ||
| "Multiple package filters can be applied by passing the flag multiple times. " | ||
| "For example --package-filter apache-airflow --package-filter apache-airflow-providers-<provider>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "The list of short hand names can be found in --help output " | |
| "Multiple package filters can be applied by passing the flag multiple times. " | |
| "For example --package-filter apache-airflow --package-filter apache-airflow-providers-<provider>", | |
| "The list of short hand names can be found in --help output " | |
| "Multiple package filters can be applied by passing the flag multiple times. " | |
| "For example --package-filter apache-airflow --package-filter apache-airflow-providers-<provider>. " | |
| "You can also specify glob-pattern. For example --package-filter '*providers*'." , |
|
Approved - proposed one NIT: improvement ( |
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
Test needs fixing
|
Closed by: #36287 |
Make the --package-filter flag a bit more clear, and demonstrate that it can be used for multiple packages.