Fix handling selective docs builds for "special" packages #35102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
approved these changes
Oct 21, 2023
amoghrajesh
reviewed
Oct 21, 2023
potiuk
force-pushed
the
fix-special-docs-packages-also-handled-as-command
branch
2 times, most recently
from
e7ee93c to
3f722dd
Compare
The apache#35069 and apache#35087 that switched from `--package-filter` to shorthand package names in CI did not handle all the cases - special package names such as "apache-airflow" or "helm-chart" were treated also as providers and the --package-filter constructed was wrong. This caused a few PRs that got "selective" documentation build (only when they changed provider + some airflow docs) would fail.
potiuk
force-pushed
the
fix-special-docs-packages-also-handled-as-command
branch
from
3f722dd to
009371e
Compare
Member
Author
|
I found also a duplication @Taragolis @amoghrajesh -> so the docs build params used their own version of converting from short-hand to filters, and I now made them common. |
potiuk
added a commit
that referenced
this pull request
Oct 29, 2023
The #35069 and #35087 that switched from `--package-filter` to shorthand package names in CI did not handle all the cases - special package names such as "apache-airflow" or "helm-chart" were treated also as providers and the --package-filter constructed was wrong. This caused a few PRs that got "selective" documentation build (only when they changed provider + some airflow docs) would fail. (cherry picked from commit a562174)
potiuk
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #35069 and #35087 that switched from
--package-filterto shorthand package names in CI did not handle all the cases - special package names such as "apache-airflow" or "helm-chart" were treated also as providers and the --package-filter constructed was wrong.This caused a few PRs that got "selective" documentation build (only when they changed provider + some airflow docs) would fail.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.