Skip to content

Conversation

@dave-pollock
Copy link
Contributor

In pandas 2.0.0, pandas.np was removed.

Airflow 2.7.0 switched to pandas 2.x, however the SalesforceHook still has a reference to pandas.np, and is therefore broken in some cases after 2.7.0, resulting in an AttributeError if the _to_timestamp method is called.

This PR switches from using pandas.np to using the numpy library directly in order to fix the issue.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 24, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uranusjr
Copy link
Member

Can a test be added to validate the fix?

@dave-pollock
Copy link
Contributor Author

@uranusjr I've added a test case. Thanks.

@dave-pollock dave-pollock requested a review from uranusjr October 29, 2023 23:44
@bolkedebruin bolkedebruin self-requested a review October 31, 2023 13:52
@bolkedebruin bolkedebruin merged commit 90a100a into apache:main Oct 31, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 31, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants