-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix SalesforceHook compatiblity with Pandas 2.x #35145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SalesforceHook compatiblity with Pandas 2.x #35145
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
…hub.com/dave-pollock/airflow into fix-salesforcehook-pandas-compatibility
|
Can a test be added to validate the fix? |
|
@uranusjr I've added a test case. Thanks. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
In pandas 2.0.0,
pandas.npwas removed.Airflow 2.7.0 switched to pandas 2.x, however the
SalesforceHookstill has a reference topandas.np, and is therefore broken in some cases after 2.7.0, resulting in anAttributeErrorif the_to_timestampmethod is called.This PR switches from using
pandas.npto using thenumpylibrary directly in order to fix the issue.