Make optional output_location attribute in AthenaOperator
#35265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
Co-authored-by: Utkarsh Sharma <utkarsharma2@gmail.com>
| mock_run_query.assert_called_once_with( | ||
| MOCK_DATA["query"], | ||
| query_context, | ||
| {}, # Should be an empty dict since we do not provide output_location |
Contributor
There was a problem hiding this comment.
Should we instead test for when we provide the output_location? or I'm missing something?
Contributor
Author
There was a problem hiding this comment.
It is tested by default in already existed tests.
utkarsharma2
approved these changes
Oct 30, 2023
Lee-W
approved these changes
Oct 30, 2023
eladkal
approved these changes
Oct 30, 2023
vincbeck
approved these changes
Oct 30, 2023
60 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output location it is not mandatory field in AWS API, so make it optional which make it possible to configure it globally on Workgroup level
Related: #35090 (comment)
See Also: https://docs.aws.amazon.com/athena/latest/ug/workgroups-settings.html
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.