(AIP-44) Migrate TaskCommand._get_ti to Internal API #35312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
mhenc
force-pushed
the
task_it
branch
2 times, most recently
from
86e8862 to
fb86359
Compare
mhenc
requested review from
XD-DENG,
ashb,
bbovenzi,
bolkedebruin,
ephraimbuddy,
kaxil,
pierrejeambrun and
ryanahamilton
as code owners
Contributor
Author
Contributor
|
There are some circular dependency issues |
potiuk
approved these changes
Nov 2, 2023
Member
|
Some tests are failing though |
vincbeck
approved these changes
Nov 2, 2023
mhenc
force-pushed
the
task_it
branch
3 times, most recently
from
59189bf to
8a23ea1
Compare
Member
|
BTW. Fix to failing "Skip Build" in #35503 |
mhenc
force-pushed
the
task_it
branch
3 times, most recently
from
1feeece to
c4c953c
Compare
Contributor
Author
|
Finally I made the tests green. There were some changes required. PTAL. |
vincbeck
approved these changes
Nov 8, 2023
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change TaskCommand._get_ti to return either TaskInstance or TaskInstancePydantic, making sure it calls the InternalAPI in dbless mode.
Some CLI commands, despite calling TaskCommand._get_ti still assume access to database.
closes: #29320
related: #29320