-
Notifications
You must be signed in to change notification settings - Fork 16.4k
feat: add read access to pools for viewer role #35352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
@marekhanus if your PR is ready you could set it in "ready for review" |
ed96e1b to
7c6eb5f
Compare
7c6eb5f to
5671389
Compare
|
Rebase done. Conflicts after ad717ef are now resolved. |
5671389 to
718fc8a
Compare
718fc8a to
df69c67
Compare
raphaelauv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@marekhanus could you please rebase on main , to trigger a new CI test run |
df69c67 to
1e3711e
Compare
|
the test |
Cluster Activity UI shows `FAILED TO FETCH DATA` error in pools section. Users with Viewer role do not have permission to read pools.
1e3711e to
661c42e
Compare
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
I'll wait for another approval before merging this. I just want to be sure that there is no historical reason for having it this way in the first place.
You get it :) |
Cluster Activity UI shows `FAILED TO FETCH DATA` error in pools section. Users with Viewer role do not have permission to read pools. (cherry picked from commit 8ae67a0)
Cluster Activity UI shows
FAILED TO FETCH DATAerror in pools section. Users with Viewer role do not have permission to read pools.Checks: