Skip to content

Conversation

@marekhanus
Copy link
Contributor

@marekhanus marekhanus commented Nov 1, 2023

Cluster Activity UI shows FAILED TO FETCH DATA error in pools section. Users with Viewer role do not have permission to read pools.

airflow k8s notino local_cluster_activity

Checks:

  • patch tested locally on Airflow 2.7.2

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Nov 1, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 1, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@raphaelauv
Copy link
Contributor

@marekhanus if your PR is ready you could set it in "ready for review"

@marekhanus marekhanus marked this pull request as ready for review November 6, 2023 17:18
@marekhanus marekhanus force-pushed the feature/activity_pool_access branch from ed96e1b to 7c6eb5f Compare November 6, 2023 18:27
@marekhanus marekhanus force-pushed the feature/activity_pool_access branch from 7c6eb5f to 5671389 Compare November 10, 2023 18:42
@marekhanus
Copy link
Contributor Author

Rebase done. Conflicts after ad717ef are now resolved.

@marekhanus marekhanus force-pushed the feature/activity_pool_access branch from 5671389 to 718fc8a Compare November 12, 2023 09:03
@marekhanus marekhanus force-pushed the feature/activity_pool_access branch from 718fc8a to df69c67 Compare November 20, 2023 17:23
Copy link
Contributor

@raphaelauv raphaelauv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphaelauv
Copy link
Contributor

@marekhanus could you please rebase on main , to trigger a new CI test run

@marekhanus marekhanus force-pushed the feature/activity_pool_access branch from df69c67 to 1e3711e Compare November 28, 2023 12:44
@raphaelauv
Copy link
Contributor

the test test_get_user_roles_for_anonymous_user is failing

Cluster Activity UI shows `FAILED TO FETCH DATA` error in pools section. Users with Viewer role do not have permission to read pools.
@marekhanus marekhanus force-pushed the feature/activity_pool_access branch from 1e3711e to 661c42e Compare November 30, 2023 21:39
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

I'll wait for another approval before merging this. I just want to be sure that there is no historical reason for having it this way in the first place.

@potiuk
Copy link
Member

potiuk commented Nov 30, 2023

I'll wait for another approval before merging this. I just want to be sure that there is no historical reason for having it this way in the first place.

You get it :)

@eladkal eladkal merged commit 8ae67a0 into apache:main Dec 5, 2023
@eladkal eladkal added this to the Airflow 2.8.1 milestone Dec 5, 2023
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Dec 6, 2023
ephraimbuddy pushed a commit that referenced this pull request Dec 6, 2023
Cluster Activity UI shows `FAILED TO FETCH DATA` error in pools section. Users with Viewer role do not have permission to read pools.

(cherry picked from commit 8ae67a0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants