add managed identity support to AsyncDefaultAzureCredential #35394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
Lee-W
changed the title
…d make args keyword args for get_default_azure_credential
Lee-W
force-pushed
the
make-get_default_azure_credential-args-keyword-only-args
branch
from
5b28da7 to
267b538
Compare
Lee-W
changed the title
Lee-W
force-pushed
the
make-get_default_azure_credential-args-keyword-only-args
branch
from
267b538 to
8bb3f3d
Compare
Member
Author
|
Hi @potiuk , I just did some minor enhancements as a following PR of the managed identity PRs |
potiuk
approved these changes
Nov 3, 2023
Member
|
Some tests need fixing though |
Lee-W
force-pushed
the
make-get_default_azure_credential-args-keyword-only-args
branch
from
8bb3f3d to
c1f429e
Compare
60 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
…5394) * feat(providers/microsoft): add AsyncDefaultAzureCredential support and make args keyword args for get_default_azure_credential * refactor(providers/microsoft): split get_default_azure_credential into 2 functions
Lee-W
deleted the
make-get_default_azure_credential-args-keyword-only-args
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_default_azure_credentialas_get_default_azure_credentialand addget_sync_default_azure_credentialandget_async_default_azure_credential^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.