ECS Executor Health Check #35412
Merged
ECS Executor Health Check #35412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
vincbeck
approved these changes
Nov 3, 2023
potiuk
approved these changes
Nov 3, 2023
Member
|
docs failing (the non-db test is likely flake) |
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
o-nikolas
force-pushed
the
ferruzzi/ecs-executor-fail-early
branch
from
ceeff8b to
53d7378
Compare
60 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
During startup the Scheduler calls start() on the configured Executor. Attempt an API call to ECS via the Boto client in this method to test the health of the ECS Executor. This will test most of the machinery of the executor (credentials, permissions, configuration, etc). If the check fails and the executor is unhealthy don't allow the scheduler to continue to start up, fail hard and message clearly to the user what is the issue. --------- Co-authored-by: ferruzzi <ferruzzi@amazon.com> Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Scheduler startup it calls
start()on the configured Executor. Attempt an API call to ECS via the Boto client in this method to test the health of the ECS Executor. This will test most of the machinery of the executor (credentials, permissions, configuration, etc). If the check fails and the executor is unhealthy don't allow the scheduler to continue to start up, fail hard and message clearly to the user what is the issue.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.