Remove PodLoggingStatus object #35422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
dstandish
force-pushed
the
remove-pod-logging-status
branch
3 times, most recently
from
7d102e4 to
b76c05a
Compare
This object is not used anywhere. It is a legacy from the logic to periodically resume deferrable task to grab logs.
dstandish
force-pushed
the
remove-pod-logging-status
branch
from
b76c05a to
f7cebca
Compare
bolkedebruin
approved these changes
Nov 5, 2023
60 tasks
pankajkoti
added a commit
to astronomer/astronomer-providers
that referenced
this pull request
Nov 10, 2023
The release of CNCF Kubernetes Airflow provider 7.9.0 includes PR apache/airflow#35422 whih removes the PodLoggingStatus object that was getting returned that we are relying in our Async KPO operator. Since, it is a breaking change for our operator restrict the max version of the provider to 7.8.0 until which the operator works well for us. Additionally, since the Google KE engine operator also relies on the PodLoggingStatus, also restrict the max version for the Google provider to the previous stable version and restrict the dependent Kubernetes provider version to the one containing the PodLoggingStatus object
pankajkoti
added a commit
to astronomer/astronomer-providers
that referenced
this pull request
Nov 10, 2023
The release of CNCF Kubernetes Airflow provider 7.9.0 includes PR apache/airflow#35422 whih removes the PodLoggingStatus object that was getting returned that we are relying in our Async KPO operator. Since, it is a breaking change for our operator restrict the max version of the provider to 7.8.0 until which the operator works well for us. Additionally, since the Google KE engine operator also relies on the PodLoggingStatus, also restrict the max version for the Google provider to the previous stable version and restrict the dependent Kubernetes provider version to the one containing the PodLoggingStatus object
pankajkoti
added a commit
to astronomer/astronomer-providers
that referenced
this pull request
Nov 10, 2023
) The release of CNCF Kubernetes Airflow provider 7.9.0 includes PR apache/airflow#35422 whih removes the PodLoggingStatus object that was getting returned that we are relying in our Async KPO operator. Since, it is a breaking change for our operator restrict the max version of the provider to 7.8.0 until which the operator works well for us. Additionally, since the Google KE engine operator also relies on the PodLoggingStatus, also restrict the max version for the Google provider to the previous stable version and restrict the dependent Kubernetes provider version to the one containing the PodLoggingStatus object
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
This object is not used anywhere. It is a legacy from the logic to periodically resume deferrable task to grab logs.
dstandish
added a commit
to astronomer/airflow
that referenced
this pull request
Nov 23, 2023
This object was completely unused in OSS but others may have depended on it and it is kinder to remove it in a major release.
pankajkoti
added a commit
that referenced
this pull request
Nov 23, 2023
* Revert Remove PodLoggingStatus object #35422 This object was completely unused in OSS but others may have depended on it and it is kinder to remove it in a major release. * Fix param for the test --------- Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 26, 2023
* Revert Remove PodLoggingStatus object #35422 This object was completely unused in OSS but others may have depended on it and it is kinder to remove it in a major release. * Fix param for the test --------- Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This object is not used anywhere. It is a legacy from the logic to periodically resume deferrable task to grab logs.