Remove before_log in KPO retry and add traceback when interrupted #35423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
2 small logging "fixes" 1. usually tenacity retry will not be invoked. No need to add confusing log messages when there's not actually a retry. 2. When log read is interrupted and pod still running, something exceptional has happened. Let's just include the traceback rather than forcing user to enable debug logging.
dstandish
force-pushed
the
small-logging-improvements-kpo
branch
from
319ed4b to
a1faaa1
Compare
hussein-awala
approved these changes
Nov 3, 2023
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
I agree with your 2 points
60 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
…ache#35423) 2 small logging "fixes" 1. usually tenacity retry will not be invoked. No need to add confusing log messages when there's not actually a retry. 2. When log read is interrupted and pod still running, something exceptional has happened. Let's just include the traceback rather than forcing user to enable debug logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 small logging "fixes"