Skip to content

Conversation

@JDarDagran
Copy link
Contributor

@JDarDagran JDarDagran commented Nov 3, 2023

Bug description

When schema is passed explicitly in query in SnowflakeOperator information schema query is created in a wrong way. Snowflake expects uppercase names while schema is first normalized to lowercase and never uppercased when constructing information schema query

Solution

When uppercase_names is True in create_filter_clauses make schema uppercase.

when `uppercase_names` is True.

Add more relevant Snowflake test.

Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
@boring-cyborg boring-cyborg bot added area:providers provider:openlineage AIP-53 provider:snowflake Issues related to Snowflake provider labels Nov 3, 2023
@JDarDagran
Copy link
Contributor Author

This bug is quite critical for some Snowflake & OL users. I'm a bit surprised it was not found earlier.
Is there a way to ask for a patch (?) releases of common.sql and snowflake providers? Last wave of providers was just released but I'll understand if there's no such way, of course.

@potiuk
Copy link
Member

potiuk commented Nov 3, 2023

This bug is quite critical for some Snowflake & OL users. I'm a bit surprised it was not found earlier. Is there a way to ask for a patch (?) releases of common.sql and snowflake providers? Last wave of providers was just released but I'll understand if there's no such way, of course.

It's up to release manager but I do not see a need for urgency. If it was a real problem of 1000s of users, we would have known it already. Peopele often overestimate the impact of their specific problem. And users can always extend and customise the code if they BADLY need to fix it - based on this PR for example. This is open-source, and customising /patching the Open-source code (especially that patch is available, merged and scheduled for next release) is a very reasonable expectations from our users who badly need to apply a fix.

@potiuk potiuk merged commit 6858ea4 into apache:main Nov 3, 2023
@JDarDagran
Copy link
Contributor Author

@potiuk thank you for your prompt and detailed answer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:openlineage AIP-53 provider:snowflake Issues related to Snowflake provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants