-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Make raw HTML descriptions configurable #35460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make raw HTML descriptions configurable #35460
Conversation
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Few nits only.
…-description-in-params-configurable
…-description-in-params-configurable
|
Looks like all checks passed :) |
|
I think the only thing we need is |
@potiuk how about the one already in? --> https://github.com/apache/airflow/pull/35460/files#diff-1fa4ad17cb7d1ce8e7e5c724a04fceaac361d7cc44f4c27143359083cb4bb700 |
Good enough :) |
|
mentioned by CVE-2023-47265 |
With AIP-50 we introduced trigger forms and such trigger forms allow to provide raw HTML by DAG authors as descriptions.
During Airflow Summit there were some concerns discussed whether a DAG author would be able to inject dangerous JavaScript into the HTML and how Airflow handles this.
This PR changes the raw HTML support in Airflow in the way:
allow_html_in_dag_docsis added, which defaults to Falsecustom_html_formin trigger DAG UI is marked as deprecated for a future / better solution