Fix bad regexp in mypy-providers specification in pre-commits #35465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:logging
area:providers
provider:airbyte
provider:alibaba
provider:amazon
potiuk
requested review from
Lee-W,
Taragolis,
ephraimbuddy,
hussein-awala,
jedcunningham,
josh-fell,
pankajastro,
phanikumv and
utkarsharma2
Member
Author
|
Huh... We had not run mypy checks on |
potiuk
force-pushed
the
fix-bad-mypy-provider-pre-commiit-inclusion
branch
from
37cf6d8 to
ceb9a47
Compare
uranusjr
reviewed
Nov 6, 2023
Lee-W
reviewed
Nov 6, 2023
tests/system/providers/google/cloud/cloud_sql/example_cloud_sql_query_mysql.py
Outdated
Show resolved
Hide resolved
tests/system/providers/google/cloud/cloud_sql/example_cloud_sql_query_postgres.py
Outdated
Show resolved
Hide resolved
tests/system/providers/google/cloud/data_loss_prevention/example_dlp_info_types.py
Outdated
Show resolved
Hide resolved
tests/system/providers/google/cloud/dataplex/example_dataplex.py
Outdated
Show resolved
Hide resolved
uranusjr
reviewed
Nov 6, 2023
uranusjr
reviewed
Nov 6, 2023
tests/system/providers/google/cloud/vertex_ai/example_vertex_ai_pipeline_job.py
Outdated
Show resolved
Hide resolved
uranusjr
reviewed
Nov 6, 2023
tests/system/providers/google/cloud/cloud_sql/example_cloud_sql_query_postgres.py
Outdated
Show resolved
Hide resolved
uranusjr
reviewed
Nov 6, 2023
tests/system/providers/google/cloud/cloud_sql/example_cloud_sql_query_mysql.py
Outdated
Show resolved
Hide resolved
uranusjr
reviewed
Nov 6, 2023
tests/system/providers/google/cloud/automl/example_automl_translation.py
Outdated
Show resolved
Hide resolved
The mypy-providers specification has been wrong for tests/providers and tests/system/providers so a number of tests there has not been checked with type-hinting with MyPy. This PR fixes the specification and all the tests that were breaking mypy checks
potiuk
force-pushed
the
fix-bad-mypy-provider-pre-commiit-inclusion
branch
from
ceb9a47 to
081e3e6
Compare
Member
Author
uranusjr
reviewed
Nov 6, 2023
Member
Author
|
Look forward to merging those. The more we wait, the more likely we will have some new cases popping up |
Taragolis
approved these changes
Nov 6, 2023
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
…#35465) The mypy-providers specification has been wrong for tests/providers and tests/system/providers so a number of tests there has not been checked with type-hinting with MyPy. This PR fixes the specification and all the tests that were breaking mypy checks
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mypy-providers specification has been wrong for tests/providers and tests/system/providers so a number of tests there has not been checked with type-hinting with MyPy. This PR fixes the specification and all the tests that were breaking mypy checks
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.