Split AWS Links tests into separate modules #35484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
Taragolis
force-pushed
the
split-aws-links-tests
branch
from
6d4e2b8 to
ca9b48e
Compare
Taragolis
added
changelog:skip
Taragolis
commented
Nov 6, 2023
Contributor
Author
There was a problem hiding this comment.
🙄 git still think that this renamed file. This will be a surprise for someone who will go thought the git history and git blame
potiuk
approved these changes
Nov 7, 2023
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
* Split AWS Links tests into separate modules * Add Glue Link(s) tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, maybe my initial idea with tests all links in the one go was not so good.
Another "genius" idea it test in the separate modules by reusable test class with 3 tests cases:
In addition add missing
EmrLogsLinktest and found minor bugEmrLogsLink.format_linkwhich plan to fix as follow up, since it should be caught webserverrelated: #35442
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.