Fix Bullseye PROD build step #35487
Merged
Fix Bullseye PROD build step #35487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
fix-bullseye-prod-build
branch
from
687a3ce to
1f591fe
Compare
The Bullseye PRD build step in `main` is failing after switching to bookworm - for two reasons: 1) The CI image used to build packages is pulled using bullseye TAG 2) The bullseye tag is wrong - containing `"` This PR fixes that by: * separating out CI image pull for the build from composite action to build production image * fixing the tag * updates names of job and steps to show clearly Bullseye
potiuk
force-pushed
the
fix-bullseye-prod-build
branch
from
1f591fe to
c3ec192
Compare
potiuk
requested review from
amoghrajesh,
eladkal,
ephraimbuddy,
hussein-awala,
jedcunningham and
pankajkoti
vincbeck
approved these changes
Nov 6, 2023
hussein-awala
approved these changes
Nov 6, 2023
Member
Author
|
Failed tests unrelated. Merging. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 7, 2023
The PROD build step in regular workflow should be skipped but after recent bullseye-related change apache#35487, the step fails because of missing check for in-workflow-build. This PR fixes those.
potiuk
added a commit
that referenced
this pull request
Nov 7, 2023
The PROD build step in regular workflow should be skipped but after recent bullseye-related change #35487, the step fails because of missing check for in-workflow-build. This PR fixes those.
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
The Bullseye PRD build step in `main` is failing after switching to bookworm - for two reasons: 1) The CI image used to build packages is pulled using bullseye TAG 2) The bullseye tag is wrong - containing `"` This PR fixes that by: * separating out CI image pull for the build from composite action to build production image * fixing the tag * updates names of job and steps to show clearly Bullseye
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
…35503) The PROD build step in regular workflow should be skipped but after recent bullseye-related change apache#35487, the step fails because of missing check for in-workflow-build. This PR fixes those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bullseye PRD build step in
mainis failing after switching to bookworm - for two reasons:"This PR fixes that by:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.