Increase timeout for flaky Test_BranchPythonDecoratedOperator test #35511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to apache#35473 - this test sometimes (very rarely) exceeds the default 60 seconds timeout when run in Paralllel test environment where we have multiple containers and multiple databases and multiple parallel tests runnign at the same time on single virtual machine (in order to maximise the gains from parallelism). This test sometimes fails with **just** above 60 seconds, so following the 3x rule explained in the long description of reasoning why we are doing it apache#35473 (comment)
Member
Author
|
Very similar case as #35473 |
vincbeck
approved these changes
Nov 7, 2023
eladkal
approved these changes
Nov 7, 2023
potiuk
deleted the
increase-timeout-for-python-decorated-operator-tests
branch
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 9, 2023
As a follow-up after apache#35511 it turned out that we have THREE tests which are named Test_BranchDecoratedOperator - because they were copied originally from the "Python" one - there is a Python, ExternalPython and PythonVirtualenv tests :). The apache#35551 only added timeout in one of them - and in the least problematic one at that (Python). This PR also adds it in the other tests and renames the tests classes to distinguish between the different tests (to more easily see which one failed).
potiuk
added a commit
that referenced
this pull request
Nov 9, 2023
As a follow-up after #35511 it turned out that we have THREE tests which are named Test_BranchDecoratedOperator - because they were copied originally from the "Python" one - there is a Python, ExternalPython and PythonVirtualenv tests :). The #35551 only added timeout in one of them - and in the least problematic one at that (Python). This PR also adds it in the other tests and renames the tests classes to distinguish between the different tests (to more easily see which one failed).
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
…pache#35511) Similar to apache#35473 - this test sometimes (very rarely) exceeds the default 60 seconds timeout when run in Paralllel test environment where we have multiple containers and multiple databases and multiple parallel tests runnign at the same time on single virtual machine (in order to maximise the gains from parallelism). This test sometimes fails with **just** above 60 seconds, so following the 3x rule explained in the long description of reasoning why we are doing it apache#35473 (comment)
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
As a follow-up after apache#35511 it turned out that we have THREE tests which are named Test_BranchDecoratedOperator - because they were copied originally from the "Python" one - there is a Python, ExternalPython and PythonVirtualenv tests :). The apache#35551 only added timeout in one of them - and in the least problematic one at that (Python). This PR also adds it in the other tests and renames the tests classes to distinguish between the different tests (to more easily see which one failed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #35473 - this test sometimes (very rarely) exceeds the default 60 seconds timeout when run in Paralllel test environment where we have multiple containers and multiple databases and multiple parallel tests runnign at the same time on single virtual machine (in order to maximise the gains from parallelism).
This test sometimes fails with just above 60 seconds, so following the 3x rule explained in the long description of reasoning why we are doing it #35473 (comment)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.