feat: K8S resource operator - CRD #35600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
raphaelauv
force-pushed
the
feature/k8s_crd
branch
from
ef5a4ff to
dc2e476
Compare
raphaelauv
requested review from
hussein-awala and
jedcunningham
as code owners
raphaelauv
force-pushed
the
feature/k8s_crd
branch
from
43e0282 to
17ea599
Compare
potiuk
approved these changes
Nov 21, 2023
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
LGTM. Do not know all the details but it does look good. to create the resources
Small NIT: @raphaelauv would be nice to have test_k8s_resource_iterator.py with a unit test for it - looks nicely unit-testable and we are eyeing to move things out of the list in test_proect_structure rather than add to the list.
potiuk
approved these changes
Nov 22, 2023
Contributor
Author
|
@potiuk thanks for the review 👍 |
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 23, 2023
* feat: K8S resource operator - CRD * clean * tests * remove sensor ( for another PR ) * clean * test on k8s_resource_iterator
69 tasks
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 26, 2023
* feat: K8S resource operator - CRD * clean * tests * remove sensor ( for another PR ) * clean * test on k8s_resource_iterator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current K8S resource operators do not work with CRD
example rayjob of the kuberay operator and so on
this PR add support to airflow to create /
sensor/ delete CRD in K8S--
I will do another PR for the sensor