Skip to content

Conversation

@tokoko
Copy link
Contributor

@tokoko tokoko commented Nov 15, 2023

After #25935 SerializedDagModel.remove_deleted_dags is supposed to clean up dags only belonging to a single dag processor, but it's being ignored because processor_subdir column in serialized_dag table is never populated from dagbag in the first place.

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 15, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@hussein-awala hussein-awala requested a review from mhenc November 15, 2023 20:42
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Nov 20, 2023
@eladkal eladkal added this to the Airflow 2.7.4 milestone Nov 20, 2023
@mhenc mhenc requested a review from potiuk November 20, 2023 10:42
@potiuk potiuk merged commit 8a302d3 into apache:main Nov 20, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 20, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants