Remove backcompat inheritance for DbApiHook #35754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
approved these changes
Nov 20, 2023
eladkal
approved these changes
Nov 20, 2023
potiuk
reviewed
Nov 20, 2023
| """ | ||
|
|
||
|
|
||
| # In case we are running it on Airflow 2.4+, we should use BaseHook, but on Airflow 2.3 and below |
potiuk
reviewed
Nov 20, 2023
| if "jwt__file" in extra: | ||
| with open(extra.get("jwt__file")) as jwt_file: | ||
| token = jwt_file.read() | ||
| if not exactly_one(jwt_file := "jwt__file" in extra, jwt_token := "jwt__token" in extra): |
Member
There was a problem hiding this comment.
Any particular reason we have those changes ? They look unrelated to 2.4 compatibility removal. Should we separate it out?
Contributor
Author
There was a problem hiding this comment.
They look unrelated to 2.4 compatibility removal.
After change inheritance this block of code do not pass static checks
Contributor
Author
There was a problem hiding this comment.
There was the way to fix it by different way, however I preferred to add additional validation
potiuk
approved these changes
Nov 20, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 23, 2023
* Remove backcompat inheritance for DbApiHook * jwt_file > jwt__file * simplify trino test
69 tasks
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 26, 2023
* Remove backcompat inheritance for DbApiHook * jwt_file > jwt__file * simplify trino test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up: #35727, #35752
Remove inheritance from backcompat classes and fix static checks
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.