Make EksPodOperator exec config not rely on log level #35771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
syedahsn
force-pushed
the
syedahsn/eks-pod-exec-config-update
branch
2 times, most recently
from
5123626 to
6570f47
Compare
o-nikolas
reviewed
Nov 21, 2023
o-nikolas
approved these changes
Nov 22, 2023
69 tasks
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 26, 2023
* Wrap bash inline script around eks_get_token.py to suppress log output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the mechanism for getting credentials to authenticate to the EKS pod by wrapping the
eks_get_token.pyscript and printing the credentials out tostdout, without having to interact with the Airflow log level. This makes it more robust, and less dependent on external variables.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.