Remove --force-build command in cache steps in CI #35784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--force-build` command has not been used for a long time in the `ci-image build` command for quite some time because the sheer fact that you run the command means that you want to run the build (so it made no sense to have it). The command only makes sense when you want to force build when running `breeze` or `breeze start-airflow` command. However commands to build cache in CI still had this command used and it caused the builds to fail after merging apache#35768 when the option has been removed (it was not detected there, because cache steps only run in main build)
potiuk
requested review from
amoghrajesh,
pankajkoti and
vincbeck
and removed request for
pankajkoti
Member
Author
|
Small follow-up - I could not fully test it before merge as those jobs are only happening in "canary" build. Example failures: https://github.com/apache/airflow/actions/runs/6945658746/job/18895580360 |
eladkal
approved these changes
Nov 21, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 23, 2023
The `--force-build` command has not been used for a long time in the `ci-image build` command for quite some time because the sheer fact that you run the command means that you want to run the build (so it made no sense to have it). The command only makes sense when you want to force build when running `breeze` or `breeze start-airflow` command. However commands to build cache in CI still had this command used and it caused the builds to fail after merging #35768 when the option has been removed (it was not detected there, because cache steps only run in main build)
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 26, 2023
The `--force-build` command has not been used for a long time in the `ci-image build` command for quite some time because the sheer fact that you run the command means that you want to run the build (so it made no sense to have it). The command only makes sense when you want to force build when running `breeze` or `breeze start-airflow` command. However commands to build cache in CI still had this command used and it caused the builds to fail after merging #35768 when the option has been removed (it was not detected there, because cache steps only run in main build)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--force-buildcommand has not been used for a long time in theci-image buildcommand for quite some time because the sheer fact that you run the command means that you want to run the build (so it made no sense to have it). The command only makes sense when you want to force build when runningbreezeorbreeze start-airflowcommand.However commands to build cache in CI still had this command used and it caused the builds to fail after merging #35768 when the option has been removed (it was not detected there, because cache steps only run in main build)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.