Avoid breeze self-upgrade run in some pre-commits. #35802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
approved these changes
Nov 22, 2023
After recent refactors, some of the pre-commits imported breeze code and accidentally triggered breeze self-upgrade. This slowed them down a bit because every time they run breeze attempted to self-upgrade. This was especially visible in mypy. This PR sets "SKIP_UPGRADE_CHECK" by all the pre-commits which skips the self-upgrade during breeze importing.
potiuk
force-pushed
the
avoid-breeze-self-upgrade-in-pre-commits
branch
from
321964f to
c8a6733
Compare
vincbeck
approved these changes
Nov 22, 2023
Member
Author
|
All right - static checks passed and they were the only ones changed here. Mergingl |
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 26, 2023
After recent refactors, some of the pre-commits imported breeze code and accidentally triggered breeze self-upgrade. This slowed them down a bit because every time they run breeze attempted to self-upgrade. This was especially visible in mypy. This PR sets "SKIP_UPGRADE_CHECK" by all the pre-commits which skips the self-upgrade during breeze importing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent refactors, some of the pre-commits imported breeze code and accidentally triggered breeze self-upgrade. This slowed them down a bit because every time they run breeze attempted to self-upgrade. This was especially visible in mypy.
This PR sets "SKIP_UPGRADE_CHECK" by all the pre-commits which skips the self-upgrade during breeze importing.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.