Skip to content

Conversation

@ferruzzi
Copy link
Contributor

@ferruzzi ferruzzi commented Nov 23, 2023

Should fix #35789

"attempts" is a required field if retry_strategy is used. By doing it this way, we can also verify that a user-provided retry_strategy has a valid attempts value.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Nov 23, 2023
@ferruzzi
Copy link
Contributor Author

ferruzzi commented Nov 23, 2023

One possible point to discuss: The 'attempts' value must be between 1 and 10. The API will return a ClientError if a value outside that range is provided. Do we want to catch that at init or just let the API handle it at runtime? I'm tempted to let the API handle it so we don't have to chase it if/when they make a change to the available range.

@eladkal eladkal merged commit a794e0d into apache:main Nov 23, 2023
@vincbeck vincbeck deleted the ferruzzi/fix-batch-operator-retries branch November 23, 2023 16:18
@ferruzzi ferruzzi restored the ferruzzi/fix-batch-operator-retries branch December 8, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants