Ignore E402 (import not at the top of file) in pre-commits #35873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
Taragolis,
eladkal,
hussein-awala and
pierrejeambrun
jscheffl
approved these changes
Nov 26, 2023
hussein-awala
approved these changes
Nov 26, 2023
Pre-commits often import some modules from elsewhere after inserting a common folder at PYTHONPATH. Pre-commits are pretty special, because they are supposed to be run as standalone scripts by pre-commit framework as git hooks, and they often do similar things, so some common code in pre-commits is good to have. Ignoring E402 error in all pre-commits seems like best way to avoid unnecessary individual exclusions.
potiuk
force-pushed
the
ignore-import-top-level-error-in-pre-commits
branch
from
2b90ac1 to
e14f426
Compare
Member
Author
|
random errors. Need to stlll look at docker stability - but that's unrelated. |
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-commits often import some modules from elsewhere after inserting a common folder at PYTHONPATH. Pre-commits are pretty special, because they are supposed to be run as standalone scripts by pre-commit framework as git hooks, and they often do similar things, so some common code in pre-commits is good to have.
Ignoring E402 error in all pre-commits seems like best way to avoid unnecessary individual exclusions.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.