Convert mypy pre-commits to use breeze shell to run them #35877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Based on #35875 |
potiuk
force-pushed
the
use-breeze-shell-in-mypy-pre-commits
branch
2 times, most recently
from
9846780 to
a50a248
Compare
The Mypy static checks now use breze shell to execute, also they force color so the errors are seen with coloured output even when they are run as part of git hook. Scripts folder needs to be added in its entirety in order to be able to run the mypy check without mounting the volumes to running container - but relying on the code already in the image.
potiuk
force-pushed
the
use-breeze-shell-in-mypy-pre-commits
branch
from
a50a248 to
a43aa57
Compare
potiuk
commented
Nov 27, 2023
vincbeck
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mypy static checks now use breze shell to execute, also they
force color so the errors are seen with coloured output even when
they are run as part of git hook.
Scripts folder needs to be added in its entirety in order to be
able to run the mypy check without mounting the volumes to
running container - but relying on the code already in the image.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.