Move pre-commit for local-file-mounts to breeze shell #35878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Based on #35875 |
potiuk
force-pushed
the
move-pre-commit-local-mounts-sync-to-breeze-shell
branch
from
a6d2f0b to
522c5c2
Compare
potiuk
force-pushed
the
move-pre-commit-local-mounts-sync-to-breeze-shell
branch
from
522c5c2 to
50c79d8
Compare
amoghrajesh
reviewed
Nov 27, 2023
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Generally looks good, small nits
potiuk
added
the
debug ci resources
The pre-commit is moved to be run via breeze shell. The code to do so has been migrated to new breeze command.
potiuk
force-pushed
the
move-pre-commit-local-mounts-sync-to-breeze-shell
branch
from
50c79d8 to
548abc7
Compare
Member
Author
|
Same here another #35830 off-spring |
amoghrajesh
approved these changes
Nov 27, 2023
potiuk
added a commit
that referenced
this pull request
Dec 15, 2023
The pre-commit is moved to be run via breeze shell. The code to do so has been migrated to new breeze command. (cherry picked from commit 07e40bd)
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-commit is moved to be run via breeze shell. The code to do
so has been migrated to new breeze command.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.