Skip to content

Conversation

@bolkedebruin
Copy link
Contributor

This adds documentation for developers on how to use serde and when to apply it.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member

potiuk commented Nov 27, 2023

Looks cool.

I am not sure we need to add separate section and whether it should be put in "airflow.apache.org" documentation.

I believe generally for quite long time we've been following the patter to separte the "developer/contributor" documentation from user documentation.

It used to be that these two types of docs were intermixed In airflow.apache.org - but over last few years you will find that we moved most of this documentation to files that live in GitHub repository, while leaving the airflow.apache.org to users.

There might stil be a few of those docs in airlfow.apache.org, and there is a little overlap wiith https://airflow.apache.org/docs/apache-airflow/stable/public-airflow-interface.html (which are stll list all the things that Airlfow users and Provider developers can rely on as public), the detailed documentation lives in the code, usually close to the code the documentation describes.

Few examples (some of them are really starting points and need a lot more love - like your document does)

Benefit of doing it is that they can be linked to "main" version in GitHub - not to the "stable" version of Airflow (the latter being updated far less frequently and tied with specific version). Also we can then refer to the documentation from the code of Airflow (for example in exceptions etc.).

Also both .md and .rst are natively rendered by GitHub, so it's really nice way of sharing the developer docs.

So seems like natural place for this kind of doc is

https://github.com/apache/airflow/tree/main/tests/serialization/README.rst maybe?

@bolkedebruin
Copy link
Contributor Author

Haha, a nice way of saying, why did you not look over there ;-)

@potiuk
Copy link
Member

potiuk commented Nov 27, 2023

Haha, a nice way of saying, why did you not look over there ;-)

Well. IF the exception where serialization failed would point to the docs in GitHub and explain "go there and read how you can fix the problem (maybe)", then it's likely that someone (not ncessarily me) who had no idea that it can be done this way would look here.

So adding documentation is one thing, dragging attention and directing the contributor (and maintainers) to the place increases the chances of success if our goal is "let's use serde approach for similar cases" - if that's the goal.

Then it does not matter where it is ...

@eladkal
Copy link
Contributor

eladkal commented Dec 10, 2023

I believe generally for quite long time we've been following the patter to separte the "developer/contributor" documentation from user documentation.

True. Contributor docs are not kept on Airflow site but on Github

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jan 25, 2024
@github-actions github-actions bot closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:documentation stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants