Make rootless-docker documented first-class-citizen in Breeze#35917
Merged
potiuk merged 1 commit intoapache:mainfrom Nov 28, 2023
Merged
Make rootless-docker documented first-class-citizen in Breeze#35917potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
potiuk
requested review from
amoghrajesh,
eladkal and
uranusjr
and removed request for
ashb and
jedcunningham
amoghrajesh
approved these changes
Nov 28, 2023
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Few nits otherwise looks good
Taragolis
approved these changes
Nov 28, 2023
Since rootless docker is becoming more and more popular and soon likely becomes standard, we should recognise it in our decisions when it comes to runnig Breeze as it changes some of the basic assumptions about files and ownership we had when we designed how we are running containers in Breeze. Reviewed the places where "rootless docker" had an impact and fixed a typo in fix-ownership (it did not matter because fix-ownership was not even executed in linux in the first place, but it should be fixed for consistency). Documented the rootless docker in the ADRs for breeze as this is building on top of the ADR 6 and ADR 14 where the root user and ownership fixing decisions were made.
potiuk
force-pushed
the
rootless-docker-as-first-class-citizen
branch
from
5ed95ec to
5394e2c
Compare
potiuk
added a commit
that referenced
this pull request
Dec 15, 2023
Since rootless docker is becoming more and more popular and soon likely becomes standard, we should recognise it in our decisions when it comes to runnig Breeze as it changes some of the basic assumptions about files and ownership we had when we designed how we are running containers in Breeze. Reviewed the places where "rootless docker" had an impact and fixed a typo in fix-ownership (it did not matter because fix-ownership was not even executed in linux in the first place, but it should be fixed for consistency). Documented the rootless docker in the ADRs for breeze as this is building on top of the ADR 6 and ADR 14 where the root user and ownership fixing decisions were made. (cherry picked from commit 6bbe63b)
ephraimbuddy
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since rootless docker is becoming more and more popular and soon likely becomes standard, we should recognise it in our decisions when it comes to runnig Breeze as it changes some of the basic assumptions about files and ownership we had when we designed how we are running containers in Breeze.
Reviewed the places where "rootless docker" had an impact and fixed a typo in fix-ownership (it did not matter because fix-ownership was not even executed in linux in the first place, but it should be fixed for consistency).
Documented the rootless docker in the ADRs for breeze as this is building on top of the ADR 6 and ADR 14 where the root user and ownership fixing decisions were made.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.