Skip port forwarding also for base ports when running pre-commits #35922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pre-commits are run and breeze shell is opened they were both attempting to use the same port forwarding. However pre-commits do not ever need port forwarding because the forwarded ports are only needed when you run breeze shell interactively. This is a follow-up afte apache#35862. This PR removes port forwarding when "pre-commit" project name is used to run breeze shell command.
potiuk
requested review from
Taragolis,
amoghrajesh,
eladkal,
ephraimbuddy and
pankajkoti
potiuk
added a commit
that referenced
this pull request
Dec 15, 2023
…5922) When pre-commits are run and breeze shell is opened they were both attempting to use the same port forwarding. However pre-commits do not ever need port forwarding because the forwarded ports are only needed when you run breeze shell interactively. This is a follow-up afte #35862. This PR removes port forwarding when "pre-commit" project name is used to run breeze shell command. (cherry picked from commit ad04d2a)
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pre-commits are run and breeze shell is opened they were both attempting to use the same port forwarding. However pre-commits do not ever need port forwarding because the forwarded ports are only needed when you run breeze shell interactively.
This is a follow-up afte #35862.
This PR removes port forwarding when "pre-commit" project name is used to run breeze shell command.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.