Skip to content

Conversation

@andar9
Copy link
Contributor

@andar9 andar9 commented Dec 4, 2023

I think the date 14.19.2023 is wrong--should it be 14.09.2023 (= September 14, 2023)?

I think the date 14.19.2023 is wrong--should it be 14.09.2023 (= September 14, 2023)?
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 4, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Dec 4, 2023

I think the date 14.19.2023 is wrong--should it be 14.09.2023 (= September 14, 2023)?

I'd quite agree :).

@potiuk potiuk merged commit 55d8137 into apache:main Dec 4, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 4, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Dec 5, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.0 milestone Dec 5, 2023
ephraimbuddy pushed a commit that referenced this pull request Dec 5, 2023
I think the date 14.19.2023 is wrong--should it be 14.09.2023 (= September 14, 2023)?

(cherry picked from commit 55d8137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants