Use UTC explicitly in timetable tests #36082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
approved these changes
Dec 6, 2023
potiuk
approved these changes
Dec 6, 2023
eladkal
approved these changes
Dec 7, 2023
These tests logically depend on the fact that the test suite is run in UTC. While that is true and expected to remain this way for the foreseeable future, it is better to make them use UTC explicitly. Note that timetables are expected to return times in UTC anyway.
Pendulum does not implement caching in the constructor, but with a wrapper function. This causes issues in tests due to classes such as Timezone does not implement equality, making asserts difficult. By using the wrapper functions instead, we can help Pendulum produces equal values more consistently.
uranusjr
force-pushed
the
use-utc-in-timetable-tests
branch
from
591f2cd to
8944682
Compare
Taragolis
approved these changes
Dec 7, 2023
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 11, 2024
(cherry picked from commit c1d28b3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion #35887 (review)
These tests logically depend on the fact that the test suite is run in UTC. While that is true and expected to remain this way for the foreseeable future, it is better to make them use UTC explicitly.
Note that timetables are expected to return times in UTC anyway.