Refactor ExternalDagLink to not create ad hoc TaskInstances #36135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-fell
force-pushed
the
external-dag-link
branch
from
d3e0743 to
8bb189c
Compare
This operator link creates an ad hoc TaskInstance to build its output URL. Generally we moved away from this approach starting with apache#21285. This PR updates the operator link to use `TaskInstance.get_task_instance()` instead.
josh-fell
force-pushed
the
external-dag-link
branch
from
8bb189c to
4b16d30
Compare
eladkal
approved these changes
Dec 9, 2023
hussein-awala
approved these changes
Dec 10, 2023
potiuk
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This operator link creates an ad hoc TaskInstance to build its output URL. Generally we moved away from this approach starting with #21285.
This PR updates the operator link to use
TaskInstance.get_task_instance()instead.