Fix extra "USE_AIRFLOW_VERSION" variable set in sdist package check #36154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are testing packages in main, we also test sdist packages, and main is the only build we run it, so when implementing apache#36131 we had no chance to test it. There was an etra USE_AIRFLOW_VERSION variable set in the job and it caused failed attempt of reinstalling sdist package when entering constraints generation. This variable is now removed, only the --use-airflow-version flags in breeze commands that need it are used.
Member
Author
eladkal
approved these changes
Dec 10, 2023
potiuk
deleted the
remove-extra-use-airflow-version-in-sdist-providers-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are testing packages in main, we also test sdist packages, and main is the only build we run it, so when implementing #36131 we had no chance to test it. There was an etra USE_AIRFLOW_VERSION variable set in the job and it caused failed attempt of reinstalling sdist package when entering constraints generation.
This variable is now removed, only the --use-airflow-version flags in breeze commands that need it are used.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.