Avoid race condition when generating constraints/installing providers #36155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Fixes problem that happened here: https://github.com/apache/airflow/actions/runs/7158634372/attempts/1?pr=36152 |
The change apache#36131 when switching to docker-compose based running of scripts introduced a subtle race condition when several docker-compose runs were running in paralell and used the same project_name. This happened for example in case of constraints generation - when running two Python constraints generation caused docker network to be created two times. This PR fixes the problem for the cases where such run are run in parallel - by giving each of the parallel commands unique project_name.
potiuk
force-pushed
the
avoid-race-condition-when-generating-constraints
branch
from
4cb4d0c to
1f58b1d
Compare
eladkal
approved these changes
Dec 10, 2023
potiuk
added a commit
that referenced
this pull request
Dec 15, 2023
…#36155) The change #36131 when switching to docker-compose based running of scripts introduced a subtle race condition when several docker-compose runs were running in paralell and used the same project_name. This happened for example in case of constraints generation - when running two Python constraints generation caused docker network to be created two times. This PR fixes the problem for the cases where such run are run in parallel - by giving each of the parallel commands unique project_name. (cherry picked from commit 643b234)
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change #36131 when switching to docker-compose based running of scripts introduced a subtle race condition when several docker-compose runs were running in paralell and used the same project_name. This happened for example in case of constraints generation - when running two Python constraints generation caused docker network to be created two times.
This PR fixes the problem for the cases where such run are run in parallel - by giving each of the parallel commands unique project_name.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.