Rewrite constraints generation in Python #36158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
Lee-W,
Taragolis,
eladkal,
ephraimbuddy,
pankajkoti,
pierrejeambrun,
uranusjr and
utkarsharma2
eladkal
approved these changes
Dec 10, 2023
potiuk
force-pushed
the
rewrite-generate-constraints-in-python
branch
from
c8f3e7d to
c85da98
Compare
potiuk
force-pushed
the
rewrite-generate-constraints-in-python
branch
3 times, most recently
from
12a3908 to
46d7fad
Compare
Lee-W
reviewed
Dec 10, 2023
potiuk
force-pushed
the
rewrite-generate-constraints-in-python
branch
3 times, most recently
from
adc72ba to
5b115da
Compare
Historically constraints generation (like most in-container scripts) were written in Bash. But since then we rewrote all of the scripts that had some logic to Python - generating constraints was the last one to rewrite (all the other scripts are simple and probably makes sense to keep them in Bash. The scripts have a bit improved diagnostics and output now. Fixes: #26019
potiuk
force-pushed
the
rewrite-generate-constraints-in-python
branch
from
5b115da to
501bd4e
Compare
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Dec 11, 2023
The new constraints generation implemented in apache#36158 had a bug that constraint files have not been generated when there was no changes (wrong file has been deleted). This resulted in PROD files generation failing when there were no new releases to one of 670 dependencies. This PR fixes it and improves the diagnostics of comstraints generation: * more information printed about generated files * using shorten method wnen running commands (will add ellipsis if longer) * failing when there are not constraints to upload - indicating a bug in the processs of constraints generation rather than when downloaded constraints are missing.
potiuk
added a commit
that referenced
this pull request
Dec 11, 2023
The new constraints generation implemented in #36158 had a bug that constraint files have not been generated when there was no changes (wrong file has been deleted). This resulted in PROD files generation failing when there were no new releases to one of 670 dependencies. This PR fixes it and improves the diagnostics of comstraints generation: * more information printed about generated files * using shorten method wnen running commands (will add ellipsis if longer) * failing when there are not constraints to upload - indicating a bug in the processs of constraints generation rather than when downloaded constraints are missing.
potiuk
added a commit
that referenced
this pull request
Dec 15, 2023
Historically constraints generation (like most in-container scripts) were written in Bash. But since then we rewrote all of the scripts that had some logic to Python - generating constraints was the last one to rewrite (all the other scripts are simple and probably makes sense to keep them in Bash. The scripts have a bit improved diagnostics and output now. Fixes: #26019 (cherry picked from commit f39cdcc)
potiuk
added a commit
that referenced
this pull request
Dec 15, 2023
The new constraints generation implemented in #36158 had a bug that constraint files have not been generated when there was no changes (wrong file has been deleted). This resulted in PROD files generation failing when there were no new releases to one of 670 dependencies. This PR fixes it and improves the diagnostics of comstraints generation: * more information printed about generated files * using shorten method wnen running commands (will add ellipsis if longer) * failing when there are not constraints to upload - indicating a bug in the processs of constraints generation rather than when downloaded constraints are missing. (cherry picked from commit 20a7f92)
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically constraints generation (like most in-container scripts)
were written in Bash. But since then we rewrote all of the scripts
that had some logic to Python - generating constraints was the last
one to rewrite (all the other scripts are simple and probably makes
sense to keep them in Bash.
The scripts have a bit improved diagnostics and output now.
Fixes: #26019
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.