Enable native HPA for Airflow Workers #36174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pemiranda-clgx
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
It looks good; I just added a small comment about the chosen type for the HPA metrics.
amoghrajesh
reviewed
Dec 22, 2023
amoghrajesh
reviewed
Jan 3, 2024
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Thanks for making the changes @pemiranda-clgx
I have one concern regarding versioning.
It should be /v2 for K8S >= 1.23 and /v2beta2 for < 1.23
potiuk
approved these changes
Jan 5, 2024
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
LGTM. @hussein-awala @amoghrajesh ?
10 tasks
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add K8S native Horizontal Pod Autoscaler in Airflow Workers to support autoscaling based on external custom metrics.