Fix AirflowSkipException message raised by BashOperator #36354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
bash-exit-code
branch
2 times, most recently
from
8502561 to
19e8778
Compare
dolfinus
force-pushed
the
bash-exit-code
branch
from
19e8778 to
7006587
Compare
dolfinus
force-pushed
the
bash-exit-code
branch
from
7006587 to
fa5fbf8
Compare
hussein-awala
approved these changes
Dec 21, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 11, 2024
(cherry picked from commit 667a5b2)
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BashOperator.skip_on_exit_codeis always a container (likelist[int]), it cannot beNone.AirflowSkipExceptionshould contain exact exit code instead of container value.BashOperator(skip_no_exit_code=0)to skip successfully finished scripts. Previously it was the same asBashOperator(skip_no_exit_code=[]). This is the result of discussion Fix AirflowSkipException message raised by KubernetesPodOperator #36355 (review)^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.