Check redshift cluster state before deferring to triggerer #36416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
Lee-W
changed the title
Lee-W
force-pushed
the
check-cluster-state-before-defer-to-triggerer
branch
from
f52ba51 to
a0a9cda
Compare
pankajkoti
reviewed
Dec 26, 2023
Lee-W
force-pushed
the
check-cluster-state-before-defer-to-triggerer
branch
from
8abfc67 to
d1e50b4
Compare
pankajkoti
reviewed
Dec 26, 2023
Lee-W
force-pushed
the
check-cluster-state-before-defer-to-triggerer
branch
from
d1e50b4 to
ad12d5c
Compare
Lee-W
force-pushed
the
check-cluster-state-before-defer-to-triggerer
branch
2 times, most recently
from
0310ade to
40f8e08
Compare
Contributor
|
Same comment as #36523, I am not sure we want to do that |
Member
Author
Replied in #36523 (comment) |
19 tasks
Lee-W
force-pushed
the
check-cluster-state-before-defer-to-triggerer
branch
from
40f8e08 to
07d21e7
Compare
…heck cluster_state before deferring logic
Lee-W
force-pushed
the
check-cluster-state-before-defer-to-triggerer
branch
from
07d21e7 to
d412b50
Compare
Member
Author
|
@pankajkoti Please let me know if there's any other concern on this PR when you're available. Thanks! |
Lee-W
force-pushed
the
check-cluster-state-before-defer-to-triggerer
branch
from
d412b50 to
28f4a03
Compare
pankajkoti
approved these changes
Jan 6, 2024
Member
pankajkoti
left a comment
pankajkoti
left a comment
There was a problem hiding this comment.
I think good to wait for another pair of eyes.
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running a task in deferrable mode, the condition might already be met before we defer the task into the trigger. This PR intends to check the redshift cluster status before deferring the task to trigger.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.